proto: Remove superfluous #[doc(hidden)] fuzzing
#2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module is already `#[cfg(fuzzing)]`, which should make it not appear in docs.
9 tasks
Ralith
approved these changes
Dec 20, 2024
djc
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is already
#[cfg(fuzzing)], which should make it not appear in docs.See #2097
I manually confirmed that the module doesn't appear when running
cargo doclocally. However, I'm aware that docs.rs does some stuff about annotating which conditions different items are feature-gated behind, platform-gated behind, etc, which runningcargo docdoesn't. I don't know how that works, whether it's a feature of cargo doc or something docs.rs has hacked on top, or how to recreate it locally. I'm hoping that it being#[cfg(fuzzing)]--notably, not a feature--will make it just not appear. But if we notice that it's popped up on the next release then we might have to revert.